From c0373e9cd48b0fc22ac295fdab51a29e3df7a0cd Mon Sep 17 00:00:00 2001 From: Christian Beier Date: Tue, 7 Sep 2010 17:43:58 +0200 Subject: Non-blocking sockets for Windows. Expands the SetNonBlocking() function in libvncclient/sockets.c to also work under Windows and also changes it to honour maybe already present socket flags. A similar function was introduced for libvncserver as well and all the #ifdef'ed fnctl calls replaced with calls to that one. Signed-off-by: Christian Beier --- libvncserver/sockets.c | 40 +++++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 15 deletions(-) (limited to 'libvncserver/sockets.c') diff --git a/libvncserver/sockets.c b/libvncserver/sockets.c index fa7ea92..01f5642 100755 --- a/libvncserver/sockets.c +++ b/libvncserver/sockets.c @@ -116,12 +116,8 @@ rfbInitSockets(rfbScreenInfoPtr rfbScreen) if (rfbScreen->inetdSock != -1) { const int one = 1; -#ifndef WIN32 - if (fcntl(rfbScreen->inetdSock, F_SETFL, O_NONBLOCK) < 0) { - rfbLogPerror("fcntl"); + if(!rfbSetNonBlocking(rfbScreen->inetdSock)) return; - } -#endif if (setsockopt(rfbScreen->inetdSock, IPPROTO_TCP, TCP_NODELAY, (char *)&one, sizeof(one)) < 0) { @@ -270,13 +266,10 @@ rfbCheckFds(rfbScreenInfoPtr rfbScreen,long usec) return -1; } -#ifndef WIN32 - if (fcntl(sock, F_SETFL, O_NONBLOCK) < 0) { - rfbLogPerror("rfbCheckFds: fcntl"); - closesocket(sock); + if(!rfbSetNonBlocking(sock)) { + closesocket(sock); return -1; } -#endif if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, (char *)&one, sizeof(one)) < 0) { @@ -418,13 +411,10 @@ rfbConnect(rfbScreenInfoPtr rfbScreen, return -1; } -#ifndef WIN32 - if (fcntl(sock, F_SETFL, O_NONBLOCK) < 0) { - rfbLogPerror("fcntl failed"); - closesocket(sock); + if(!rfbSetNonBlocking(sock)) { + closesocket(sock); return -1; } -#endif if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, (char *)&one, sizeof(one)) < 0) { @@ -705,3 +695,23 @@ rfbListenOnUDPPort(int port, return sock; } + +/* + * rfbSetNonBlocking sets a socket into non-blocking mode. + */ +rfbBool +rfbSetNonBlocking(int sock) +{ +#ifdef WIN32 + unsigned long block=1; + if(ioctlsocket(sock, FIONBIO, &block) == SOCKET_ERROR) { + errno=WSAGetLastError(); +#else + int flags = fcntl(sock, F_GETFL); + if(flags < 0 || fcntl(sock, F_SETFL, flags | O_NONBLOCK) < 0) { +#endif + rfbLogPerror("Setting socket to non-blocking failed"); + return FALSE; + } + return TRUE; +} -- cgit v1.2.3