From e16029cbc251fd37ab1b601ea12e9e12efed4e60 Mon Sep 17 00:00:00 2001 From: Koichiro IWAO Date: Wed, 17 Jan 2018 16:13:22 +0900 Subject: fix leak of SCP_DISCONNECTED_SESSION Pointed out by: #919 --- sesman/libscp/libscp_v1c.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'sesman/libscp/libscp_v1c.c') diff --git a/sesman/libscp/libscp_v1c.c b/sesman/libscp/libscp_v1c.c index 5401dda3..dfc3754d 100644 --- a/sesman/libscp/libscp_v1c.c +++ b/sesman/libscp/libscp_v1c.c @@ -177,6 +177,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (0 != scp_tcp_force_recv(c->in_sck, c->in_s->data, 8)) { + g_free(ds); return SCP_CLIENT_STATE_NETWORK_ERR; } @@ -184,6 +185,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (version != 1) { + g_free(ds); return SCP_CLIENT_STATE_VERSION_ERR; } @@ -191,6 +193,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (size < 12) { + g_free(ds); return SCP_CLIENT_STATE_SIZE_ERR; } @@ -198,6 +201,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (0 != scp_tcp_force_recv(c->in_sck, c->in_s->data, size - 8)) { + g_free(ds); return SCP_CLIENT_STATE_NETWORK_ERR; } @@ -205,6 +209,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (cmd != SCP_COMMAND_SET_DEFAULT) { + g_free(ds); return SCP_CLIENT_STATE_SEQUENCE_ERR; } @@ -212,6 +217,7 @@ scp_v1c_get_session_list(struct SCP_CONNECTION *c, int *scount, if (cmd != 42) { + g_free(ds); return SCP_CLIENT_STATE_SEQUENCE_ERR; } -- cgit v1.2.3