LibVNCClient: make sure ReadFromRFBServer() does not write after buffer end in CoRRE decoding

Closes #250
7 years ago · 09f2f3fb6a
parent c3115350eb
commit 09f2f3fb6a
1 changed files with 1 additions and 1 deletions
--- a/libvncclient/corre.c
+++ b/libvncclient/corre.c
@ -48,7 +48,7 @@ HandleCoRREBPP (rfbClient* client, int rx, int ry, int rw, int rh)

    client->GotFillRect(client, rx, ry, rw, rh, pix);

-    if (!ReadFromRFBServer(client, client->buffer, hdr.nSubrects * (4 + (BPP / 8))))
+    if (hdr.nSubrects * (4 + (BPP / 8)) > RFB_BUFFER_SIZE || !ReadFromRFBServer(client, client->buffer, hdr.nSubrects * (4 + (BPP / 8))))
 	return FALSE;

    ptr = (uint8_t *)client->buffer;