Fix usage of condition variable in TQThread which could lead to a thread being run multiple times in parallel.

Although highly unlikely, the following situation was possible:
- a thread is restarted while still running. The call to the second 'start()' blocks because the thread is still running
- the OS decides to randomly wake up the thread that called 'start()'
- a second thread is started and runs in parallel to the first thread, with obvious undefined behavior

Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>

1 files changed, 5 insertions, 3 deletions

diff --git a/src/kernel/tqthread_unix.cpp b/src/kernel/tqthread_unix.cpp
index 714b35c31..a84663df6 100644
--- a/src/kernel/tqthread_unix.cpp
+++ b/src/kernel/tqthread_unix.cpp
@@ -103,7 +103,7 @@ void TQThreadInstance::init(unsigned int stackSize)
     orphan = FALSE;
     disableThreadPostedEvents = FALSE;
 
-    pthread_cond_init(&thread_done, NULL);
+    pthread_cond_init(&thread_done, nullptr);
     thread_id = 0;
 
     eventLoop = 0;
@@ -316,9 +316,11 @@ void TQThread::usleep( unsigned long usecs )
 void TQThread::start(Priority priority)
 {
     TQMutexLocker locker( d->mutex() );
+    while ( d->running )
+    {
+	pthread_cond_wait(&d->thread_done, &locker.mutex()->d->handle);
+    }
 
-    if ( d->running )
-        pthread_cond_wait(&d->thread_done, &locker.mutex()->d->handle);
     d->running = TRUE;
     d->finished = FALSE;