summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaxmikant Rashinkar <LK.Rashinkar@gmail.com>2014-07-27 14:11:02 -0700
committerLaxmikant Rashinkar <LK.Rashinkar@gmail.com>2014-07-27 14:11:02 -0700
commita9d7c13147419532cc668e797d949413de895be5 (patch)
tree4e041a9910d514efab0611d6032f3e36ae0c4c1c
parent5e537ebdfe90bb0319465423c310ce4367281ae5 (diff)
downloadxrdp-proprietary-a9d7c13147419532cc668e797d949413de895be5.tar.gz
xrdp-proprietary-a9d7c13147419532cc668e797d949413de895be5.zip
coverity: read from pointer after free
-rw-r--r--sesman/chansrv/chansrv_fuse.c3
-rw-r--r--xrdp/xrdp_mm.c2
2 files changed, 3 insertions, 2 deletions
diff --git a/sesman/chansrv/chansrv_fuse.c b/sesman/chansrv/chansrv_fuse.c
index 1d78bbfb..c4532ead 100644
--- a/sesman/chansrv/chansrv_fuse.c
+++ b/sesman/chansrv/chansrv_fuse.c
@@ -2626,7 +2626,6 @@ static void xfuse_cb_release(fuse_req_t req, fuse_ino_t ino, struct
fip, fip->fi, fip->fi->fh);
FileId = handle->FileId;
- free(handle);
fip->fi->fh = 0;
xinode->close_in_progress = 1;
@@ -2635,6 +2634,8 @@ static void xfuse_cb_release(fuse_req_t req, fuse_ino_t ino, struct
log_error("failed to send devredir_close_file() cmd");
fuse_reply_err(req, EREMOTEIO);
}
+
+ free(handle);
}
/**
diff --git a/xrdp/xrdp_mm.c b/xrdp/xrdp_mm.c
index aaa90a3a..bd8edaea 100644
--- a/xrdp/xrdp_mm.c
+++ b/xrdp/xrdp_mm.c
@@ -2374,8 +2374,8 @@ server_paint_rects(struct xrdp_mod* mod, int num_drects, short *drects,
g_malloc(sizeof(short) * num_crects * 4, 0);
if (enc_data->crects == 0)
{
- g_free(enc_data);
g_free(enc_data->drects);
+ g_free(enc_data);
return 1;
}