Make signal handlers just set a flag and move all actual logic into the
main loop. A general reminder: it's a UB to have stuff like malloc() in
signal handlers.
This partially reverts some changes made by fbd3a27d6e. Now to reset
compton config the whole session will be recreated from scratch.
Bug: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/673
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
Before that to reload settings compton-tde was using SIGUSR2; and
SIGUSR1 wasn't actully used, but was designated for something wierd.
This commit removes old SIGUSR1 handler and uses SIGUSR1 to reload the
settings instead of SIGUSR2.
Bug: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/673
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
This fixes compton launch on systems with several X11 Screens. And also
in case of multiple sessions for the same user.
Also:
- move the file to tde's proper tmp dir.
- deduplicate some code
Bug: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/673
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
`WORK_AROUND_FGLRX` is not defined anywhere in the build system. And the
code under the #ifdefs was broken for decades as `restartOnSigterm` is
not declared, defined or used anywhere.
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
X API calls for some reason were missed in previous commits.
Note: Traditionally X Api uses "True" and "False" definitions, but for
consistency with the rest of code base it would be better to use modern
counterparts.
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
There were changes made to original Konqueror graphics in #632. These were
questionable in that: a) they were an instance of fixing something that wasn't
broken; and b) editing was highly unskillful and came from a contributor that
also used AI to generate new wallpaper in TDE.
Some of these editing issues were later corrected in #649, but the texture still
exhibits transparency issues.
This commit reverts the texture to its original state, which had no issues that
needed fixing.
See tdeartwork#58
- I believe the PATH order question was resolved by place_before_in_path
function.
- tdeinit_phase1 is no more experimental after a decade.
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
Namely:
- Re-wrapping of text
- Some rewording of comments
- Replacement of back-ticks `` with $()
- A few additional output messages
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
This commit adds an option to set both: margin (space from an icon to
the border) and spacing (space between two neighbouring icons). The
option to tweak spacing was previously introduced in fa284a4598 and was
called "margin" the actual margin was reduced to 0. Unfortunately that
had its own unwanted side-effects listed in #647. Before fa284a4598 the
margin and spacing were fixed to be 1.
This commit restores old defaults for margin & spacing i.e. 1 to better
conform to config of older systems. Effectively this resolved most
issues raised in #647 and eliminates any regressions, though there are
some caveat cases when the behaviour is not ideal e.g. next settings:
panel_width=47
spacing=1
margin=0
result in next layout:
[0px][icon][2px][icon][1px]
when ideal would be:
[1px][icon][1px][icon][1px]
On the other hand in such a case a user should probably just use
margin=spacing=1.
Besides that commit contains some minor refactoring.
Bug: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/647
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
.. to see which XDG_CONFIG_DIRS are set by the script.
This is interesting on platform which use this environment varialble
to find the desktop files from the trinity installation.
See https://mirror.git.trinitydesktop.org/gitea/TDE/tde/issues/232
for a use case where this kind of output is useful.
Signed-off-by: Bernhard Reiter <bernhard@intevation.de>